SCS mirror sync fails due to git passwords encoding issues with some chars

Products

• Support Only for Spring

Issue/Introduction

Issue

For Spring Cloud Services version 3.1.10 and above, creating SCS config-server service using gihub URL fails with error:

status: create failed
message: CF-HttpClientTimeout(10001): The request to the service broker timed out: https://scs-mirror-service.domain.example.com/v2/service_instances/647038b7-1a0c-4fec-8f22-ec9bdbc3d155?accepts_incomplete=true
started: 2020-06-30T21:16:03Z
updated: 2020-06-30T21:17:08Z

Broker logs report below:

2020-06-30 21:18:20.346  INFO 6 --- [ctor-http-nio-1] i.p.s.c.mirrorservice.mirrors.ShellUtil  : remote: HTTP Basic: Access denied
2020-06-30 21:18:20.346  INFO 6 --- [ctor-http-nio-1] i.p.s.c.mirrorservice.mirrors.ShellUtil  : fatal: Authentication failed for 'https://gitlab.example.com/someuser/testrepo/java/java-maven-oracle-config/'
2020-06-30 21:18:20.351 ERROR 6 --- [ctor-http-nio-1] .m.b.MirrorEnabledServiceInstanceService : Failed to create mirror 

Cause

The password used for the GitLab account has a combination of reserved and unsafe chars from a URL perspective.
Example: Password: Oj#d:un;J$W,123
Some chars in this field are not encoded during the mirror cloning phase.

Environment

Product Version: Other

Resolution

Workaround

Do not use the special characters like, # in the password.
 

Permanent Fix

Upgrade SCS to 3.1.14